[JVM Windows] Process shutdown bug #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Apr 7, 2025
|
Let's see if merging the test changes does something about the flakiness 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For JVM we currently find the PowerSync SQLite core resource's path then copy it to a temporary file. The temporary file is used when loading the extension in SQLite. The temporary file is deleted on process shutdown.
#161 raised that on Windows an issue occurs when deleting the temporary file.
It looks like this method, of using a temporary file, was used in order to resolve the extension's path in a format compatible with Windows. Typically the
R::class.java.getResource(path)result is of the format/c:/...which does not seem to work as an extension path in SQLite.The logic has been updated to avoid the use of temporary files altogether. The binary resource file path is now used to load the SQLite extension.